[webkit-reviews] review granted: [Bug 187200] Add utility methods to WebResourceLoadStatisticsStore to hop back and forth between threads : [Attachment 343962] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 187200: Add utility methods to WebResourceLoadStatisticsStore to hop back
and forth between threads
https://bugs.webkit.org/show_bug.cgi?id=187200

Attachment 343962: Patch

https://bugs.webkit.org/attachment.cgi?id=343962&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 343962
  --> https://bugs.webkit.org/attachment.cgi?id=343962
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343962&action=review

Looks much tidier! r=me.

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:86
>      ASSERT(RunLoop::isMain());

We can get rid of this ASSERT here, can't we?

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:96
>      ASSERT(RunLoop::isMain());

Ditto.

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:106
>      ASSERT(RunLoop::isMain());

Ditto.