[webkit-reviews] review requested: [Bug 187196] Don't use tracePoints in JS/Wasm entry : [Attachment 343959] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 29 15:54:54 PDT 2018


Saam Barati <sbarati at apple.com> has asked  for review:
Bug 187196: Don't use tracePoints in JS/Wasm entry
https://bugs.webkit.org/show_bug.cgi?id=187196

Attachment 343959: patch

https://bugs.webkit.org/attachment.cgi?id=343959&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 343958
  --> https://bugs.webkit.org/attachment.cgi?id=343958
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343958&action=review

r=me with fix.

>> Source/WebCore/workers/WorkerThread.cpp:146
>> +	    Thread::setCurrentThreadIsUserInteractive();
> 
> need to revert this.

I was just about to ask. :)

--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Created attachment 343959

  --> https://bugs.webkit.org/attachment.cgi?id=343959&action=review

patch


More information about the webkit-reviews mailing list