[webkit-reviews] review granted: [Bug 187195] teach bisect-builds to fetch supported platforms from the rest api : [Attachment 343951] patch for review

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Lucas Forschler
<lforschler at apple.com>'s request for review:
Bug 187195: teach bisect-builds to fetch supported platforms from the rest api
https://bugs.webkit.org/show_bug.cgi?id=187195

Attachment 343951: patch for review

https://bugs.webkit.org/attachment.cgi?id=343951&action=review




--- Comment #3 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 343951
  --> https://bugs.webkit.org/attachment.cgi?id=343951
patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=343951&action=review

> Tools/Scripts/bisect-builds:202
> +    r = urllib2.urlopen(platform_url)

You can consider making a separate method to fetching data from url, e.g.:
fetch_data_from_url(url). That method can be used in fetch_revision_list() as
well.
But that can be done later on in a separate patch as well.

> Tools/Scripts/bisect-builds:206
> +    for platform in data['Items']:

Is data guaranteed to have 'Items' key. what if data is empty? Do we want to
crash here?

You might consider using data.get('Items')