[webkit-reviews] review granted: [Bug 187189] Regression(r233359): Caused ITP tests to be flaky : [Attachment 343930] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 29 13:19:31 PDT 2018


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 187189: Regression(r233359): Caused ITP tests to be flaky
https://bugs.webkit.org/show_bug.cgi?id=187189

Attachment 343930: Patch

https://bugs.webkit.org/attachment.cgi?id=343930&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 343930
  --> https://bugs.webkit.org/attachment.cgi?id=343930
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343930&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1481
> +    resolveDirectoriesIfNecessary();

That seems a bit odd to call it there but I guess this is fine since this is a
method called only by our test infrastructure.


More information about the webkit-reviews mailing list