[webkit-reviews] review granted: [Bug 186771] [WPE]: Add a way to setup our development environment inside flatpak : [Attachment 343911] Patch.

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 186771: [WPE]: Add a way to setup our development environment inside
flatpak
https://bugs.webkit.org/show_bug.cgi?id=186771

Attachment 343911: Patch.

https://bugs.webkit.org/attachment.cgi?id=343911&action=review




--- Comment #48 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 343911
  --> https://bugs.webkit.org/attachment.cgi?id=343911
Patch.

I think this is now good enough to commit. Thanks a lot for the work!

Running layout tests with it is still kind of broken.

I get this:
Regressions: Unexpected text-only failures (929)
Regressions: Unexpected image-only failures (157)
Regressions: Unexpected audio failures (1)
Regressions: Unexpected crashes (2)
Regressions: Unexpected timeouts (395)

The failures are somehow expected due to the different system, but the timeouts
have to be investigated and fixed. Also the api tests are broken. I will report
a bug about that...

But let's commit this so others can start testing and report/fix bugs as they
appear

Thanks for this!