[webkit-reviews] review granted: [Bug 187154] Resource Load Statistics: Don't create a WebResourceLoadStatisticsStore for ephemeral sessions : [Attachment 343865] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 187154: Resource Load Statistics: Don't create a
WebResourceLoadStatisticsStore for ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=187154

Attachment 343865: Patch

https://bugs.webkit.org/attachment.cgi?id=343865&action=review




--- Comment #9 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 343865
  --> https://bugs.webkit.org/attachment.cgi?id=343865
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343865&action=review

r=me, but I'm afraid you'll need to rebase your patch (after Chris's change)
before you can land.

> Source/WebKit/ChangeLog:9
> +	   Most of the changes in this patch removes the boolean parameter for
tracking

"Most of the changes in this patch REMOVE the boolean parameter for tracking"

>> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1478
>>  
> 
> We should probably ASSERT(!m_sessionID.isEphemeral()) here.

Agreed!