[webkit-reviews] review granted: [Bug 187181] Returning PiP'd video to fullscreen while playing leaves video muted. : [Attachment 343918] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 29 09:23:41 PDT 2018


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 187181: Returning PiP'd video to fullscreen while playing leaves video
muted.
https://bugs.webkit.org/show_bug.cgi?id=187181

Attachment 343918: Patch

https://bugs.webkit.org/attachment.cgi?id=343918&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 343918
  --> https://bugs.webkit.org/attachment.cgi?id=343918
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343918&action=review

> LayoutTests/media/picture-in-picture-interruption.html:34
> +    <div>This tests that video is in the correct media session state after
enting a background interruption while pipped.</div>

Nit: "enting"


More information about the webkit-reviews mailing list