[webkit-reviews] review requested: [Bug 186771] [WPE]: Add a way to setup our development environment inside flatpak : [Attachment 343911] Patch.

[bugzilla-daemon at webkit.org]

Thibault Saunier <tsaunier at gnome.org> has asked  for review:
Bug 186771: [WPE]: Add a way to setup our development environment inside
flatpak
https://bugs.webkit.org/show_bug.cgi?id=186771

Attachment 343911: Patch.

https://bugs.webkit.org/attachment.cgi?id=343911&action=review




--- Comment #47 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 343911

  --> https://bugs.webkit.org/attachment.cgi?id=343911&action=review

Patch.

(In reply to Carlos Alberto Lopez Perez from comment #46)
> Comment on attachment 343861 [details]
> Patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343861&action=review
> 
> > Tools/flatpak/org.webkit.WebKit.yaml:187
> > +  - name: libgcrypt # Speedup libgrcypt
> > +	 sources:
> > +	   - type: git
> > +	     url: https://dev.gnupg.org/source/libgcrypt.git
> > +	     branch: libgcrypt-1.7.6
> > +	   - type: patch
> > +	     path:
../gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch
> 
> It doesn't build:
> 
> configure: error: libgpg-error is needed.
>		  See ftp://ftp.gnupg.org/gcrypt/libgpg-error/ .
> Error: module libgcrypt: Child process exited with code 1
> Traceback (most recent call last):
>   File "Tools/Scripts/update-webkitgtk-flatpak", line 28, in <module>
>     WebkitFlatpak.load_from_args(["--gtk", "--update"] + sys.argv[1:]).run()
>   File "./Tools/flatpak/flatpakutils.py", line 710, in run
>     return self.setup_dev_env()
>   File "./Tools/flatpak/flatpakutils.py", line 737, in setup_dev_env
>     subprocess.check_call(builder_args)
>   File "/usr/lib/python2.7/subprocess.py", line 186, in check_call
>     raise CalledProcessError(retcode, cmd)
> subprocess.CalledProcessError: Command '['flatpak-builder',
> '--disable-rofiles-fuse', '--state-dir',
> '/home/clopez/webkit/webkit/WebKitBuild/FlatpakCache', '--ccache',
> '/home/clopez/webkit/webkit/WebKitBuild/GTK/FlatpakTreeRelease',
> '--force-clean',
> '/home/clopez/webkit/webkit/WebKitBuild/FlatpakCache/org.webkit.GTK-
> generated.json', '--build-only', '--stop-at=org.webkit.GTK']' returned
> non-zero exit status 1


Oops, sorryt about that. Fixed.