[webkit-reviews] review granted: [Bug 98345] [WK2] fast/parser/document-open-in-unload.html makes the following test crash : [Attachment 343701] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 28 23:33:21 PDT 2018
Ryosuke Niwa <rniwa at webkit.org> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 98345: [WK2] fast/parser/document-open-in-unload.html makes the following
test crash
https://bugs.webkit.org/show_bug.cgi?id=98345
Attachment 343701: Patch
https://bugs.webkit.org/attachment.cgi?id=343701&action=review
--- Comment #23 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 343701
--> https://bugs.webkit.org/attachment.cgi?id=343701
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=343701&action=review
> Source/WebCore/loader/FrameLoader.cpp:2014
> + && m_documentLoader // m_documentLoader can become null by detaching
the frame.
I don't think this comment adds any value. Please remove.
r=me with the comment removed.
More information about the webkit-reviews
mailing list