[webkit-reviews] review granted: [Bug 187141] Add the first unit test for dump_class_layout : [Attachment 343809] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 187141: Add the first unit test for dump_class_layout
https://bugs.webkit.org/show_bug.cgi?id=187141

Attachment 343809: Patch

https://bugs.webkit.org/attachment.cgi?id=343809&action=review




--- Comment #5 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 343809
  --> https://bugs.webkit.org/attachment.cgi?id=343809
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343809&action=review

> Tools/lldb/lldb_dump_class_layout.py:146
> +	   target = debugger.CreateTargetWithFileAndArch(str(self.binary_path),
architecture)

I had issues using this API and switched to CreateTarget(). I take it the
issues have since been resolved. See <rdar://problem/39960149> for more
details.