[webkit-reviews] review granted: [Bug 187143] Make sure the WebResourceLoadStatisticsStore gets destroyed on the main thread : [Attachment 343857] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 187143: Make sure the WebResourceLoadStatisticsStore gets destroyed on the
main thread
https://bugs.webkit.org/show_bug.cgi?id=187143

Attachment 343857: Patch

https://bugs.webkit.org/attachment.cgi?id=343857&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 343857
  --> https://bugs.webkit.org/attachment.cgi?id=343857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343857&action=review

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:188
> +    m_statisticsQueue->dispatch([this, protectedThis = makeRef(*this),
origins = WTFMove(origins)]() mutable {

origins should be isolated except if we are sure they are coming straight from
IPC.
We should add a comment saying why this is ok.
And we should probably make
WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated private to ensure
it does not get used out of IPC.

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:258
>  void
WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener(String&&
primaryDomainInNeedOfStorageAccess, uint64_t openerPageID, String&&
openerPrimaryDomain, bool isTriggeredByUserGesture)

Ditto.