[webkit-reviews] review granted: [Bug 187148] [ews-build] Add support for WebKitPy-Tests-EWS : [Attachment 343827] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 28 12:48:40 PDT 2018


Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 187148: [ews-build] Add support for WebKitPy-Tests-EWS
https://bugs.webkit.org/show_bug.cgi?id=187148

Attachment 343827: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=343827&action=review




--- Comment #8 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 343827
  --> https://bugs.webkit.org/attachment.cgi?id=343827
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343827&action=review

r=me after fixing type and ensuring unit tests run.

> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:298
> +class TestunWebKitPyTests(BuildStepMixinAdditions, unittest.TestCase):

typo here


More information about the webkit-reviews mailing list