[webkit-reviews] review denied: [Bug 187133] Switch OS(FUCHSIA) to using JSCOnly : [Attachment 343792] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 27 23:21:20 PDT 2018


Yusuke Suzuki <utatane.tea at gmail.com> has denied Adam Barth
<abarth at webkit.org>'s request for review:
Bug 187133: Switch OS(FUCHSIA) to using JSCOnly
https://bugs.webkit.org/show_bug.cgi?id=187133

Attachment 343792: Patch

https://bugs.webkit.org/attachment.cgi?id=343792&action=review




--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 343792
  --> https://bugs.webkit.org/attachment.cgi?id=343792
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343792&action=review

> ChangeLog:9
> +	   Rather than creating a Fuchsia port, OS(FUCHSIA) now uses the
JSCOnly
> +	   port.

OK, then, I think we should remove Fuchsia related things in webkitdir.pm. We
can pass cmakeargs by using `--cmakeargs`.
So basically, `Tools/Scripts/build-jsc --jsc-only
--cmakeargs="-DCMAKE_TOOLCHAIN_FILE=XXX"` should work.

> Tools/Scripts/webkitdirs.pm:152
> +my $targetingFuchsia;

If we use JSCOnly port in Fuchsia OS, I think we do not need to check Fuchsia
related things in webkitdirs.pm. We can just use `--jsc-only`, and we can
remove Fuchsia related things in webkitdirs.pm.

> Tools/Scripts/webkitdirs.pm:2212
> +    my $toolchainFile = $ENV{'CMAKE_TOOLCHAIN_FILE'};
> +    if ($toolchainFile) {
> +	   push @args, "-DCMAKE_TOOLCHAIN_FILE=$toolchainFile";
> +    }

Why not passing it with `cmakeargs`? `Tools/Scripts/build-jsc
--cmakeargs="-DCMAKE_TOOLCHAIN_FILE=XXX"`


More information about the webkit-reviews mailing list