[webkit-reviews] review granted: [Bug 187106] Add logging to try to diagnose where we get a null structure. : [Attachment 343729] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 187106: Add logging to try to diagnose where we get a null structure.
https://bugs.webkit.org/show_bug.cgi?id=187106

Attachment 343729: Patch

https://bugs.webkit.org/attachment.cgi?id=343729&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 343729
  --> https://bugs.webkit.org/attachment.cgi?id=343729
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343729&action=review

r=me with additional ChangeLog comment.

> Source/JavaScriptCore/ChangeLog:9
> +	   Add a logging to JSObject::toPrimitive to help diagnose a nullptr
> +	   structure crash.

Can you please add a note that this logging is disabled by default, and
requires a code change + rebuild to enable it?