[webkit-reviews] review denied: [Bug 98345] [WK2] fast/parser/document-open-in-unload.html makes the following test crash : [Attachment 343585] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 98345: [WK2] fast/parser/document-open-in-unload.html makes the following
test crash
https://bugs.webkit.org/show_bug.cgi?id=98345

Attachment 343585: Patch

https://bugs.webkit.org/attachment.cgi?id=343585&action=review




--- Comment #20 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 343585
  --> https://bugs.webkit.org/attachment.cgi?id=343585
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343585&action=review

Thank you for the review.

>> Source/WebCore/loader/FrameLoader.cpp:2008
>> +	    && m_documentLoader
> 
> This is not good, we can't have the DocumentLoader disappearing at random
like this. :/ Certainly not without a warning comment. But the fact is that
anything at all can happen after calling a function of m_client. This is
similar to bug #182257. (CCs for that bug available on request.)
> 
> I wonder what Chris thinks of this solution.

There is already a null-check of m_documentLoader after calling
transitionToCommitted.
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/loader/FrameLoader.
cpp?rev=233176#L1956

I don't think so bad. I will add a comment.