[webkit-reviews] review granted: [Bug 187072] Find on page selection color isn't adapted for dark mode : [Attachment 343683] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 187072: Find on page selection color isn't adapted for dark mode
https://bugs.webkit.org/show_bug.cgi?id=187072

Attachment 343683: Patch

https://bugs.webkit.org/attachment.cgi?id=343683&action=review




--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 343683
  --> https://bugs.webkit.org/attachment.cgi?id=343683
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343683&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:406
> +    // The inactive color is normaly used, since no legacy WebKit client
marks a text match as active.

s/normaly/normally/

Also, so weird! I can iterate the matches in e.g. the Xcode docs viewer, does
that not use active state?