[webkit-reviews] review granted: [Bug 187023] [ews-build] Add support for Webkitperl-tests-EWS : [Attachment 343556] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 26 16:43:51 PDT 2018

Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 187023: [ews-build] Add support for Webkitperl-tests-EWS

Attachment 343556: Proposed patch


--- Comment #5 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 343556
  --> https://bugs.webkit.org/attachment.cgi?id=343556
Proposed patch

This patch seems fine, except for casing.
It looks like we are using all kinds of different styles here:
WebkitpyFactory I think should be WebKitPyFactory or WebKitpyFactory
TestRunWebkitperlTests -> TestRunWebKitPerlTests

name": "Webkitperl-tests-EWS" -> WebKitPerl-Tests-EWS

etc... can we standardize on using CamelCase, and making sure we capitalize the
K in WebKit ?
if this means refactoring the entire config, please do it in a separate patch
that includes the refactor globally.

More information about the webkit-reviews mailing list