[webkit-reviews] review granted: [Bug 129246] -webkit-clip-path wrong offset for clipPath references : [Attachment 340807] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 129246: -webkit-clip-path wrong offset for clipPath references
https://bugs.webkit.org/show_bug.cgi?id=129246

Attachment 340807: Patch

https://bugs.webkit.org/attachment.cgi?id=340807&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 340807
  --> https://bugs.webkit.org/attachment.cgi?id=340807
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340807&action=review

> Source/WebCore/rendering/RenderLayer.cpp:4179
> +	      
downcast<RenderSVGResourceClipper>(*element->renderer()).applyClippingToContext
(renderer(), svgReferenceBox, paintingInfo.paintDirtyRect, context);

Does hasTagName(SVGNames::clipPathTag) mean that the renderer is always a
RenderSVGResourceClipper? (I know the existing code did this.). I would feel
happier with an is<> check, otherwise this code will release-assert.