[webkit-reviews] review granted: [Bug 187016] Simplify NetworkStorageSession::getAllStorageAccessEntries() : [Attachment 343537] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 26 13:30:34 PDT 2018


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 187016: Simplify NetworkStorageSession::getAllStorageAccessEntries()
https://bugs.webkit.org/show_bug.cgi?id=187016

Attachment 343537: Patch

https://bugs.webkit.org/attachment.cgi?id=343537&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 343537
  --> https://bugs.webkit.org/attachment.cgi?id=343537
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343537&action=review

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:335
> +	   for (auto& innerPair : pair.value)

Why not using HashMap::values on both for loops?


More information about the webkit-reviews mailing list