[webkit-reviews] review granted: [Bug 187004] Tap highlight displayed when tapping a field that is already focussed : [Attachment 343509] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 26 11:23:58 PDT 2018
Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 187004: Tap highlight displayed when tapping a field that is already
focussed
https://bugs.webkit.org/show_bug.cgi?id=187004
Attachment 343509: Patch
https://bugs.webkit.org/attachment.cgi?id=343509&action=review
--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 343509
--> https://bugs.webkit.org/attachment.cgi?id=343509
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=343509&action=review
> Source/WebKit/ChangeLog:5
> +
No Radar?
> Source/WebKit/ChangeLog:9
> + _singleTapCommited: could be invoked before the tap highlight
request, causing
> + _potentialTapInProgress to be set to NO. This results in the early
return for
Really? I thought these things were all strictly ordered.
More information about the webkit-reviews
mailing list