[webkit-reviews] review requested: [Bug 186771] [WPE]: Add a way to setup our development environment inside flatpak : [Attachment 343610] Patch

[bugzilla-daemon at webkit.org]

Thibault Saunier <tsaunier at gnome.org> has asked  for review:
Bug 186771: [WPE]: Add a way to setup our development environment inside
flatpak
https://bugs.webkit.org/show_bug.cgi?id=186771

Attachment 343610: Patch

https://bugs.webkit.org/attachment.cgi?id=343610&action=review




--- Comment #33 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 343610

  --> https://bugs.webkit.org/attachment.cgi?id=343610&action=review

Patch

(In reply to Adrian Perez from comment #31)
> I finally got some spare cycles to apply this locally and try
> things a bit. First and foremost: having a reproducible build
> environment would be amazing, and I love the direction where
> this patch is pointing to.
> 
> I have just one small request: the “update-webkitgtk-flatpak”
> script requests user input, for example:
> 
>    % ./Tools/Scripts/update-webkitgtk-flatpak
>    Updating Flatpak environment for GTK (Release)
>    Looking for updates...
>    Updating in user:
>    org.gnome.Platform/x86_64/3.28 flathub 9785cf7dc622
>    Is this ok [y/n]: _
> 
> Interaction can be avoided using “flatpak install --assumeyes”,
> which would be better for automated environments like EWSs and
> any other kind of build bot. Do you think it would be possible
> to add this command line flag?


Added the option.


(In reply to Carlos Alberto Lopez Perez from comment #32)
> Comment on attachment 343401 [details]
> Patch.
> 
> Setting r- to stop the EWS bots from retrying this again and again.
> 
> Not sure why the EWS bots are unable to claim this patch is bad for them
> instead of retrying forever. Seems a bug on the EWS logic..
> 
> In any case, this is the failure they have:
> https://webkit-queues.webkit.org/results/8341006
> 
> Please upload a fixed patch that avoids that error.
> 
> I suggest that the flatpak scripts should all return early if the system is
> not linux (or the port is not GTK/WPE).

I now check if we are on linux at the very beginning.