[webkit-reviews] review granted: [Bug 186900] Fix IBeam issues with iPad apps on Mac : [Attachment 343570] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 26 09:18:18 PDT 2018


Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 186900: Fix IBeam issues with iPad apps on Mac
https://bugs.webkit.org/show_bug.cgi?id=186900

Attachment 343570: Patch

https://bugs.webkit.org/attachment.cgi?id=343570&action=review




--- Comment #17 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 343570
  --> https://bugs.webkit.org/attachment.cgi?id=343570
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343570&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3325
> +    if (_positionInformation.isSelectable)

I would still check here for whether the cached position information is valid
for the request (or maybe just check to make sure the points are close enough).


More information about the webkit-reviews mailing list