[webkit-reviews] review denied: [Bug 186771] [WPE]: Add a way to setup our development environment inside flatpak : [Attachment 343401] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 26 08:43:43 PDT 2018


Carlos Alberto Lopez Perez <clopez at igalia.com> has denied Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 186771: [WPE]: Add a way to setup our development environment inside
flatpak
https://bugs.webkit.org/show_bug.cgi?id=186771

Attachment 343401: Patch.

https://bugs.webkit.org/attachment.cgi?id=343401&action=review




--- Comment #32 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 343401
  --> https://bugs.webkit.org/attachment.cgi?id=343401
Patch.

Setting r- to stop the EWS bots from retrying this again and again.

Not sure why the EWS bots are unable to claim this patch is bad for them
instead of retrying forever. Seems a bug on the EWS logic..

In any case, this is the failure they have:
https://webkit-queues.webkit.org/results/8341006

Please upload a fixed patch that avoids that error.

I suggest that the flatpak scripts should all return early if the system is not
linux (or the port is not GTK/WPE).


More information about the webkit-reviews mailing list