[webkit-reviews] review granted: [Bug 187033] [GCrypt] Move definitions of GCryptUtilities helpers into a separate source file : [Attachment 343587] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 187033: [GCrypt] Move definitions of GCryptUtilities helpers into a
separate source file
https://bugs.webkit.org/show_bug.cgi?id=187033

Attachment 343587: Patch

https://bugs.webkit.org/attachment.cgi?id=343587&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 343587
  --> https://bugs.webkit.org/attachment.cgi?id=343587
Patch

r=me since this is clearly an improvement.

I'm not thrilled about have a bunch of free functions inside the WebCore
namespace, outside any class or other namespace. It would be nice if these
functions were inside some additional namespace.