[webkit-reviews] review granted: [Bug 186322] Switch to system malloc on iOS when nano malloc is disabled : [Attachment 343572] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 186322: Switch to system malloc on iOS when nano malloc is disabled
https://bugs.webkit.org/show_bug.cgi?id=186322

Attachment 343572: patch

https://bugs.webkit.org/attachment.cgi?id=343572&action=review




--- Comment #7 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 343572
  --> https://bugs.webkit.org/attachment.cgi?id=343572
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343572&action=review

r=me.

>> Source/bmalloc/bmalloc/BPlatform.h:241
>> +#if ((BPLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 120000) ||
(BPLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 50000) ||
(BPLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 120000)) \
> 
> I can simplify this and just make this IOS since the other two are true if
this is IOS

I'm confused is __TV_OS_VERSION_MIN_REQUIRED defined on iOS? Or are you saying
that if __IPHONE_OS_VERSION_MIN_REQUIRED >= 120000 then
__TV_OS_VERSION_MIN_REQUIRED will be >= 120000 also?

> Source/bmalloc/bmalloc/ProcessCheck.mm:62
> +	   if (NSString *appName = [[NSBundle mainBundle] bundleIdentifier]) {

Maybe we should look for an environment variable too?