[webkit-reviews] review denied: [Bug 186903] Resource Load Statistics: Make WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains() wait for the network process before calling its callback : [Attachment 343539] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied John Wilander <wilander at apple.com>'s
request for review:
Bug 186903: Resource Load Statistics: Make
WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains() wait for
the network process before calling its callback
https://bugs.webkit.org/show_bug.cgi?id=186903

Attachment 343539: Patch

https://bugs.webkit.org/attachment.cgi?id=343539&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 343539
  --> https://bugs.webkit.org/attachment.cgi?id=343539
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343539&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1213
> +	      
process->updatePrevalentDomainsToPartitionOrBlockCookies(m_sessionID,
domainsToPartition, domainsToBlock, domainsToNeitherPartitionNorBlock,
shouldClearFirst, WTFMove(completionHandler));

This is not correct and will crash if there is more than one process pool
because you keep WTFMove() ing the same completionHandler. What you want is to
use a WTF::CallbackAggregator to wait for all network processes to complete
their requests before calling completionHandler.