[webkit-reviews] review granted: [Bug 187012] Null dereference crash un ApplicationCacheGroup::startLoadingEntry() : [Attachment 343532] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 25 13:31:59 PDT 2018
youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 187012: Null dereference crash un
ApplicationCacheGroup::startLoadingEntry()
https://bugs.webkit.org/show_bug.cgi?id=187012
Attachment 343532: Patch
https://bugs.webkit.org/attachment.cgi?id=343532&action=review
--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 343532
--> https://bugs.webkit.org/attachment.cgi?id=343532
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=343532&action=review
> Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:907
> + m_entryLoader =
ApplicationCacheResourceLoader::create(m_pendingEntries.begin()->value,
documentLoader.cachedResourceLoader(), WTFMove(request), [this, requestURL]
(auto&& resourceOrError) {
We should probably [this, requestURL = WTFMove(requestURL)]
> Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:912
> + this->didFailLoadingEntry(error, m_entryLoader ?
m_entryLoader->resource()->url() : requestURL);
Can we just always use requestURL?
More information about the webkit-reviews
mailing list