[webkit-reviews] review granted: [Bug 186944] Adjust WEBCORE_EXPORT annotations for LTO : [Attachment 343380] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Keith Rollin
<krollin at apple.com>'s request for review:
Bug 186944: Adjust WEBCORE_EXPORT annotations for LTO
https://bugs.webkit.org/show_bug.cgi?id=186944

Attachment 343380: Patch

https://bugs.webkit.org/attachment.cgi?id=343380&action=review




--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 343380
  --> https://bugs.webkit.org/attachment.cgi?id=343380
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343380&action=review

r=me

> Source/WebCore/ChangeLog:29
> +	   For the most part, address these by removing the WEBCORE_EXPORT
> +	   annotation from inline methods. In some cases, move the
implementation
> +	   out-of-line because it's the class that has the WEBCORE_EXPORT on it
> +	   and removing the annotation from the class would be too disruptive.
> +	   Finally, in other cases, move the implementation out-of-line because
> +	   check-for-weak-vtables-and-externals still complains when keeping
the
> +	   implementation inline and removing the annotation; this seems to
> +	   typically (but not always) happen with destructors.

Moving destructors out-of-line can save disk space in the binary as well!

> Source/WebCore/workers/service/server/SWServer.h:72
> -	   WEBCORE_EXPORT virtual ~Connection() { }
> +	   virtual ~Connection() { }

This can be changed to:

	virtual ~Connection() = default;