[webkit-reviews] review granted: [Bug 186949] Adjust UNEXPORTED_SYMBOL_LDFLAGS for LTO : [Attachment 343398] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Keith Rollin
<krollin at apple.com>'s request for review:
Bug 186949: Adjust UNEXPORTED_SYMBOL_LDFLAGS for LTO
https://bugs.webkit.org/show_bug.cgi?id=186949

Attachment 343398: Patch

https://bugs.webkit.org/attachment.cgi?id=343398&action=review




--- Comment #6 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 343398
  --> https://bugs.webkit.org/attachment.cgi?id=343398
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343398&action=review

r=me

> Source/WebKit/Configurations/WebKit.xcconfig:118
> +UNEXPORTED_SYMBOL_LDFLAGS = -Wl,-unexported_symbol -Wl,__ZTISt9bad_alloc
-Wl,-unexported_symbol -Wl,__ZTISt9exception -Wl,-unexported_symbol
-Wl,__ZTSSt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTSSt9exception
-Wl,-unexported_symbol -Wl,__ZdlPvS_ -Wl,-unexported_symbol -Wl,__ZnwmPv
-Wl,-unexported_symbol -Wl,__Znwm -Wl,-unexported_symbol
-Wl,__ZNSt3__18functionIFvN7WebCore12PolicyActionEEEC2EOS4_
-Wl,-unexported_symbol
-Wl,__ZNSt3__18functionIFvN7WebCore12PolicyActionEEEC1EOS4_
-Wl,-unexported_symbol
-Wl,__ZNSt3__18functionIFvN7WebCore12PolicyActionEEEaSEDn
-Wl,-unexported_symbol
-Wl,__ZNKSt3__18functionIFvN7WebCore12PolicyActionEEEclES2_
-Wl,-unexported_symbol
-Wl,__ZNSt3__18functionIFvN7WebCore12PolicyActionEEE4swapERS4_
-Wl,-unexported_symbol
-Wl,__ZNSt3__18functionIFvN7WebCore12PolicyActionEEEC1ERKS4_
-Wl,-unexported_symbol
-Wl,__ZNSt3__18functionIFvN7WebCore12PolicyActionEEEC2ERKS4_
-Wl,-unexported_symbol -Wl,__ZNSt3__18functionIFvN7WebCore12PolicyActionEEED1Ev
-Wl,-unexported_symbol -Wl,__ZNSt3__18functionIFvN7WebCore12PolicyActionEEED2Ev
-Wl,-unexported_symbol
-Wl,__ZNSt3__18functionIFvN7WebCore12PolicyActionEEEaSERKS4_
-Wl,-unexported_symbol -Wl,__ZTVNSt3__117bad_function_callE
-Wl,-unexported_symbol
-Wl,__ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_
NS_13basic_istreamIcS2_EE -Wl,-unexported_symbol
-Wl,__ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_
NS_14basic_iostreamIcS2_EE -Wl,-unexported_symbol
-Wl,__ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE16
_NS_13basic_ostreamIcS2_EE -Wl,-unexported_symbol
-Wl,__ZTTNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE
-Wl,-unexported_symbol
-Wl,__ZTVNSt3__115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEEE
-Wl,-unexported_symbol
-Wl,__ZTVNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE
-Wl,-unexported_symbol
-Wl,__ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE8_
NS_13basic_ostreamIcS2_EE;

In the future, this should really be moved to a *.unexp file like was done in
WebCore; makes maintenance MUCH easier:
Source/WebCore/Configurations/WebCore.unexp