[webkit-reviews] review granted: [Bug 186788] Provide a way for Injected Bundles to indicate classes approved for secure encoding/decoding : [Attachment 343271] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 186788: Provide a way for Injected Bundles to indicate classes approved for
secure encoding/decoding
https://bugs.webkit.org/show_bug.cgi?id=186788

Attachment 343271: Patch

https://bugs.webkit.org/attachment.cgi?id=343271&action=review




--- Comment #19 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 343271
  --> https://bugs.webkit.org/attachment.cgi?id=343271
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343271&action=review

> Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundleMac.h:39
> +WK_EXPORT void WKBundleExtendClassesForParameterCoder(WKBundleRef bundle,
WKArrayRef classes);

It would be good to confirm with Brady / Alex / Geoff if we need a
corresponding Cocoa SPI for this, and where this SPI should be. I have been
told no new C API without Cocoa equivalent.

> Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundleMac.mm:42
> +void WKBundleExtendClassesForParameterCoder(WKBundleRef bundle, WKArrayRef
classes)

I think we should return early if classes is null instead of crashing.