[webkit-reviews] review granted: [Bug 186976] Web Inspector: Dark Mode: Box Model section should have dark background : [Attachment 343459] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 25 08:42:47 PDT 2018
Brian Burg <bburg at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 186976: Web Inspector: Dark Mode: Box Model section should have dark
background
https://bugs.webkit.org/show_bug.cgi?id=186976
Attachment 343459: Patch
https://bugs.webkit.org/attachment.cgi?id=343459&action=review
--- Comment #5 from Brian Burg <bburg at apple.com> ---
Comment on attachment 343459
--> https://bugs.webkit.org/attachment.cgi?id=343459
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=343459&action=review
> Source/WebInspectorUI/UserInterface/Views/DarkMode.css:739
> + .details-section .row.box-model {
Why is this not going into BoxModelDetailsSectionRow.css directly? I'd prefer
that; move any dependent variables into Variables.css if you need to.
More information about the webkit-reviews
mailing list