[webkit-reviews] review granted: [Bug 186983] Fix the composition underline to be transformed by -apple-color-filter : [Attachment 343471] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 186983: Fix the composition underline to be transformed by
-apple-color-filter
https://bugs.webkit.org/show_bug.cgi?id=186983

Attachment 343471: Patch

https://bugs.webkit.org/attachment.cgi?id=343471&action=review




--- Comment #3 from zalan <zalan at apple.com> ---
Comment on attachment 343471
  --> https://bugs.webkit.org/attachment.cgi?id=343471
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343471&action=review

> Source/WebCore/rendering/InlineTextBox.cpp:1172
> +    Color underlineColor = underline.compositionUnderlineColor ==
CompositionUnderlineColor::TextColor ?
renderer().style().visitedDependentColorWithColorFilter(CSSPropertyWebkitTextFi
llColor) : renderer().style().colorByApplyingColorFilter(underline.color);
> +    context.setStrokeColor(underlineColor);

How do you know when to use the transformed color?