[webkit-reviews] review granted: [Bug 186954] We need to have a getDirectConcurrently for use in the compilers : [Attachment 343411] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 186954: We need to have a getDirectConcurrently for use in the compilers
https://bugs.webkit.org/show_bug.cgi?id=186954

Attachment 343411: Patch

https://bugs.webkit.org/attachment.cgi?id=343411&action=review




--- Comment #8 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 343411
  --> https://bugs.webkit.org/attachment.cgi?id=343411
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343411&action=review

r=me.  If you haven't already done so, I think you should also remove the "if
(!value)" check I added in PropertyCondition::isValidValueForAttributes() due
to https://bugs.webkit.org/show_bug.cgi?id=186943.  Your changes in
attemptToMakeEquivalenceWithoutBarrier() makes that unnecessary.

> Source/JavaScriptCore/dfg/DFGGraph.cpp:1268
> +    // object pointer such that the inlinecaches told us that the object had
a structure that it

missing space between "inline" and "caches".

> Source/JavaScriptCore/dfg/DFGGraph.cpp:1270
> +    // caches had alraedy seen. And then the processor reordered the stores.
Seems unlikely and

/alraedy/already/.