[webkit-reviews] review granted: [Bug 186920] [WTF] Use Ref<> for the result type of non-failing factory functions : [Attachment 343324] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 22 17:43:09 PDT 2018


Darin Adler <darin at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 186920: [WTF] Use Ref<> for the result type of non-failing factory
functions
https://bugs.webkit.org/show_bug.cgi?id=186920

Attachment 343324: Patch

https://bugs.webkit.org/attachment.cgi?id=343324&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 343324
  --> https://bugs.webkit.org/attachment.cgi?id=343324
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343324&action=review

> Source/WTF/wtf/AutomaticThread.cpp:38
> +    return adoptRef(*new AutomaticThreadCondition());

Another thing I like to do at call sites like this one is leave out the
optional ().


More information about the webkit-reviews mailing list