[webkit-reviews] review denied: [Bug 171463] EWS QueueServer shouldn't fail to release patch if last_status is None : [Attachment 308615] Proposed patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 171463: EWS QueueServer shouldn't fail to release patch if last_status is
None
https://bugs.webkit.org/show_bug.cgi?id=171463

Attachment 308615: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=308615&action=review




--- Comment #10 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 308615
  --> https://bugs.webkit.org/attachment.cgi?id=308615
Proposed patch

last_status.message is None if an EWS bot chose to skip a patch before it
committed to take it (see AbstractPatchQueue._next_patch()). The EWS bot will
skip the patch if it failed to fetch it from Bugzilla (say, Bugzilla was down
or returned a bad response). When this happens the EWS bot does not post a
status update that it skipped the patch before it tells the status server to
release the patch. Instead the EWS should post a status update that it has
skipped the patch like it does when it skips a patch that it committed to
processing. See the ChaneLog entry in the patch on bug #186748 for more
details.