[webkit-reviews] review granted: [Bug 186819] Corner of two scroll bars is white with dark mode enabled : [Attachment 343394] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 186819: Corner of two scroll bars is white with dark mode enabled
https://bugs.webkit.org/show_bug.cgi?id=186819

Attachment 343394: Patch

https://bugs.webkit.org/attachment.cgi?id=343394&action=review




--- Comment #16 from Tim Horton <thorton at apple.com> ---
Comment on attachment 343394
  --> https://bugs.webkit.org/attachment.cgi?id=343394
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343394&action=review

The PLATFORM(MAC)s everywhere are so sad.

> Source/WebCore/PAL/pal/spi/mac/NSAppearanceSPI.h:2
> + * Copyright (C) 2015 Apple Inc.  All rights reserved.

2018

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:574
> +    auto cornerDrawingOptions =
adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault, 0,
&kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
> +
> +    CFDictionarySetValue(cornerDrawingOptions.get(), kCUIWidgetKey,
kCUIWidgetScrollBarTrackCorner);
> +    CFDictionarySetValue(cornerDrawingOptions.get(), kCUIIsFlippedKey,
kCFBooleanTrue);

Why not just a ObjC dictionary literal?