[webkit-reviews] review granted: [Bug 186878] JSImmutableButterfly can't be allocated from a subspace with HeapCell::Kind::Auxiliary : [Attachment 343368] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 186878: JSImmutableButterfly can't be allocated from a subspace with
HeapCell::Kind::Auxiliary
https://bugs.webkit.org/show_bug.cgi?id=186878

Attachment 343368: patch

https://bugs.webkit.org/attachment.cgi?id=343368&action=review




--- Comment #16 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 343368
  --> https://bugs.webkit.org/attachment.cgi?id=343368
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343368&action=review

r=me

> Source/JavaScriptCore/ChangeLog:14
> +	   are Auxiliary. This means that if the stack were the only thing
pointing to a

/the stack were/the stack is/.	"was" also works.

> Source/JavaScriptCore/heap/HeapUtil.h:107
> +		   func(pointer, candidate->handle().cellKind());

Why re-compute the cellKind() every time here?	The candidate doesn't change. 
Hence, the cellKind() shouldn't change either, no?

Oh, I see, cellKind() is only used in here.  I noticed that candidate->handle()
is computed and used multiple times.  Can you pre-compute and cache it above
instead?