[webkit-reviews] review granted: [Bug 186927] [WinCairo] ImageDiff should use DLLLauncher : [Attachment 343341] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 22 10:42:53 PDT 2018

Per Arne Vollan <pvollan at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 186927: [WinCairo] ImageDiff should use DLLLauncher

Attachment 343341: Patch


--- Comment #6 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 343341
  --> https://bugs.webkit.org/attachment.cgi?id=343341

View in context: https://bugs.webkit.org/attachment.cgi?id=343341&action=review

Looks good. R=me. Please make sure EWS is green before landing.

> Tools/ImageDiff/PlatformWin.cmake:15
> +set(IMAGE_DIFF_SOURCES ${TOOLS_DIR}/win/DLLLauncher/DLLLauncherMain.cpp)
> +set(IMAGE_DIFF_LIBRARIES shlwapi)

Should IMAGE_DIFF_SOURCES and IMAGE_DIFF_LIBRARIES be set before being
referenced, or isn't that necessary?

More information about the webkit-reviews mailing list