[webkit-reviews] review requested: [Bug 186771] [WPE]: Add a way to setup our development environment inside flatpak : [Attachment 343333] Patch

[bugzilla-daemon at webkit.org]

Thibault Saunier <tsaunier at gnome.org> has asked  for review:
Bug 186771: [WPE]: Add a way to setup our development environment inside
flatpak
https://bugs.webkit.org/show_bug.cgi?id=186771

Attachment 343333: Patch

https://bugs.webkit.org/attachment.cgi?id=343333&action=review




--- Comment #27 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 343333

  --> https://bugs.webkit.org/attachment.cgi?id=343333&action=review

Patch

(In reply to Carlos Alberto Lopez Perez from comment #26)
> More minor issues:
> 
> ====================================================================
>  WebKit is now built (00m:01s). 
>  To run MiniBrowser with this newly-built code, use the
>  "../../../../app/webkit/Tools/Scripts/run-minibrowser" script.
> ====================================================================
> 
> 
> That message should be fixed somehow, as the script name is just
> "Tools/Scripts/run-minibrowser"

Made sure we just print "Tools/Scripts/run-minibrowser" when running inside
flatpak, we can't
really figure out the host path in there. 

I also fixed wrong check that was leading to updating flatpak when calling
webkit-build.

+ Minor cleanup to check wheather `webkit-build` should be run inside flatpak.