[webkit-reviews] review granted: [Bug 183216] [iOS Debug] Multiple resourceLoadStatistics redirect tests are flaky timeouts : [Attachment 343299] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 22 08:39:15 PDT 2018


Chris Dumez <cdumez at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 183216: [iOS Debug] Multiple resourceLoadStatistics redirect tests are
flaky timeouts
https://bugs.webkit.org/show_bug.cgi?id=183216

Attachment 343299: Patch

https://bugs.webkit.org/attachment.cgi?id=343299&action=review




--- Comment #17 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 343299
  --> https://bugs.webkit.org/attachment.cgi?id=343299
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343299&action=review

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:1306
> +	   m_statisticsQueue->dispatch([completionHandler =
WTFMove(completionHandler)] () {

Do we really need to redispatch here, cannot we move the call to
completionHandler(); before the RunLoop::main().dispatch() ?


More information about the webkit-reviews mailing list