[webkit-reviews] review denied: [Bug 186900] Fix IBeam issues with iPad apps on Mac : [Attachment 343286] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 21 16:28:24 PDT 2018


Tim Horton <thorton at apple.com> has denied Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 186900: Fix IBeam issues with iPad apps on Mac
https://bugs.webkit.org/show_bug.cgi?id=186900

Attachment 343286: Patch

https://bugs.webkit.org/attachment.cgi?id=343286&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 343286
  --> https://bugs.webkit.org/attachment.cgi?id=343286
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343286&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3324
> +    if (![self ensurePositionInformationIsUpToDate:request])

Just Say No to implementing new synchronous IPC.


More information about the webkit-reviews mailing list