[webkit-reviews] review requested: [Bug 186771] [WPE]: Add a way to setup our development environment inside flatpak : [Attachment 343279] Patch.

[bugzilla-daemon at webkit.org]

Thibault Saunier <tsaunier at gnome.org> has asked  for review:
Bug 186771: [WPE]: Add a way to setup our development environment inside
flatpak
https://bugs.webkit.org/show_bug.cgi?id=186771

Attachment 343279: Patch.

https://bugs.webkit.org/attachment.cgi?id=343279&action=review




--- Comment #22 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 343279

  --> https://bugs.webkit.org/attachment.cgi?id=343279&action=review

Patch.

(In reply to Carlos Alberto Lopez Perez from comment #21)
> Comment on attachment 343238 [details]
> Patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343238&action=review
> 
> > Tools/Scripts/run-gtk-tests:134
> > +	 flatpakutils.run_in_sandbox_if_available(sys.argv)
> > +	 if not flatpakutils.is_sandboxed() and not
jhbuildutils.enter_jhbuild_environment_if_available("gtk"):
> > +	     print '***'
> > +	     print '*** Warning: jhbuild environment not present and not
running in flatpak.'
> > +	     print '*** Run update-webkitgtk-libs before build-webkit or
directly build-webkit --flatpak to ensure proper testing.'
> > +	     print '***'
> 
> This message now should reflect the last update.
> 
> - print '*** Run update-webkitgtk-libs before build-webkit or directly
> build-webkit --flatpak to ensure proper testing.'
> + print '*** Run update-webkitgtk-libs or update-webkitgtk-flatpak before
> build-webkit to ensure proper testing.'

Fixed, as well as for the following occurences.

> > Tools/Scripts/update-webkitgtk-libs:-18
> > -
> 
> This line deletion is not needed

Fixed, as well as for the following occurences.

> > Tools/flatpak/org.webkit.GTK.yaml:62
> > +- name: xvfb
> > +  sources:
> > +	 - type: git
> > +	   url: https://anongit.freedesktop.org/git/xorg/xserver.git
> > +	   branch: xorg-server-1.19.6
> > +	 - type: patch
> > +	   path: patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch
> 
> I think the patch
> xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch should be
> preserved here.
> That one is needed for making xvfb load the dri driver (swrast_dri.so) from
> the software-only mesa built at /app/softGL instead of the default's one.

Indeed, added as well as the other patch for xserver and used the exact same
configure options.