[webkit-reviews] review granted: [Bug 186861] check-webkit-style should warn about exported inline functions : [Attachment 343180] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 21 10:54:49 PDT 2018


Brent Fulgham <bfulgham at webkit.org> has granted Keith Rollin
<krollin at apple.com>'s request for review:
Bug 186861: check-webkit-style should warn about exported inline functions
https://bugs.webkit.org/show_bug.cgi?id=186861

Attachment 343180: Patch

https://bugs.webkit.org/attachment.cgi?id=343180&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 343180
  --> https://bugs.webkit.org/attachment.cgi?id=343180
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343180&action=review

Looks good. Hopefully we can activate LTO soon! Removing cq- since this checker
change can't affect windows tests.

> Tools/ChangeLog:25
> +	   Unfortunately, these errors are not emitted when LTO is not enabled,

I had to read this sentence a couple of times (double negatives). I propose:

"Unfortunately, these errors are only emitted when LTO is enabled,"


More information about the webkit-reviews mailing list