[webkit-reviews] review granted: [Bug 186873] JSPerformanceObserverCallback creates a GC strongly-referenced Function that is never cleaned up : [Attachment 343205] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 21 08:42:01 PDT 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 186873: JSPerformanceObserverCallback creates a GC strongly-referenced
Function that is never cleaned up
https://bugs.webkit.org/show_bug.cgi?id=186873

Attachment 343205: Patch

https://bugs.webkit.org/attachment.cgi?id=343205&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 343205
  --> https://bugs.webkit.org/attachment.cgi?id=343205
Patch

Nice but can we also add a test that the Document is not permanently leaked?


More information about the webkit-reviews mailing list