[webkit-reviews] review granted: [Bug 186884] [GTK] WebDriver: allow applying host-specific TLS certificates for automated sessions : [Attachment 343229] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 186884: [GTK] WebDriver: allow applying host-specific TLS certificates for
automated sessions
https://bugs.webkit.org/show_bug.cgi?id=186884

Attachment 343229: Patch

https://bugs.webkit.org/attachment.cgi?id=343229&action=review




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 343229
  --> https://bugs.webkit.org/attachment.cgi?id=343229
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343229&action=review

> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp:135
> +	       while (g_variant_iter_loop(certificates.get(), "(ss)", &host,
&certificateFile))

You are getting copies here, you need to use "(&s&s)"