[webkit-reviews] review granted: [Bug 186880] [GStreamer] ASSERTION FAILED: end.isValid() in PlatformTimeRanges::add : [Attachment 343227] Patch

[bugzilla-daemon at webkit.org]

Alicia Boya García <aboya at igalia.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 186880: [GStreamer] ASSERTION FAILED: end.isValid() in
PlatformTimeRanges::add
https://bugs.webkit.org/show_bug.cgi?id=186880

Attachment 343227: Patch

https://bugs.webkit.org/attachment.cgi?id=343227&action=review




--- Comment #4 from Alicia Boya García <aboya at igalia.com> ---
Comment on attachment 343227
  --> https://bugs.webkit.org/attachment.cgi?id=343227
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343227&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1116
> +	   if (loaded.isValid() && loaded)

LGTM. This will still create an empty [0, 0) range in some situations though.
It maybe good to add `&& loaded > MediaTime::zeroTime()` to avoid that.