[webkit-reviews] review granted: [Bug 186856] [Fullscreen] Suspend page (and pause video) while phishing warining is presented : [Attachment 343164] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 186856: [Fullscreen] Suspend page (and pause video) while phishing warining
is presented
https://bugs.webkit.org/show_bug.cgi?id=186856

Attachment 343164: Patch

https://bugs.webkit.org/attachment.cgi?id=343164&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 343164
  --> https://bugs.webkit.org/attachment.cgi?id=343164
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343164&action=review

> Source/WebKit/ChangeLog:3
> +	   [Fullscreen] Suspend page (and pause video) while phishing warining
is presented

warining?

> Source/WebCore/html/HTMLMediaElement.cpp:5603
> +		   m_shouldUnpauseInternalOnResume = true;
> +		   setPausedInternal(true);

This could use an explanation in the changelog.

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:453
> +	   page->suspendActiveDOMObjectsAndAnimations();

Should we also suspend/defer layer tree commits? Is this enough to actually
stop painting? Do you even care?