[webkit-reviews] review requested: [Bug 186771] [WPE]: Add a way to setup our development environment inside flatpak : [Attachment 343195] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 20 17:35:25 PDT 2018

Thibault Saunier <tsaunier at gnome.org> has asked  for review:
Bug 186771: [WPE]: Add a way to setup our development environment inside

Attachment 343195: Patch.


--- Comment #16 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 343195

  --> https://bugs.webkit.org/attachment.cgi?id=343195&action=review


(In reply to Carlos Alberto Lopez Perez from comment #15)
> Comment on attachment 343191 [details]
> Patch.
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343191&action=review
> > Tools/ChangeLog:14
> > +	     The workflow is very similar to the "jhbuild based" on except that
when running `build-webkit` you need to pass
> > +	     the `--flatpak` argument, afterward, other script will detect that
a flatpak based environment
> > +	     has been setup and will be used.
> Can we have a way of enabling flatpak environment that can be called before
> "build-webkit" and can we make the "build-webkit" script smart enough to
> detect that this previous step has been called and do the expected thing?
> The bots run a "jhbuild" step before the step "build-webkit". But the step
> "build-webkit" doesn't receive any special parameter. It simply auto-detects
> the JHBuild dir and enables it if its there.
> So the idea is to replace the step "jhbuild" with a step "flatpak", but
> without having to pass any extra parameter to the step/script "build-webkit".

You can now do `mkdir -p WebKitBuild/GTK/FlatpakTreeRelease && build-webkit
--release --gtk` or
`mkdir -p WebKitBuild/WPE/FlatpakTreeRelease && build-webkit --debug --wpe`

Is that enough?

More information about the webkit-reviews mailing list