[webkit-reviews] review denied: [Bug 186821] [Fullscreen] Add a pinch-to-exit gesture : [Attachment 343108] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 20 17:24:50 PDT 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 186821: [Fullscreen] Add a pinch-to-exit gesture
https://bugs.webkit.org/show_bug.cgi?id=186821

Attachment 343108: Patch

https://bugs.webkit.org/attachment.cgi?id=343108&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 343108
  --> https://bugs.webkit.org/attachment.cgi?id=343108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343108&action=review

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:289
> +    progressTransform.a *= scale;
> +    progressTransform.b *= scale;
> +    progressTransform.c *= scale;
> +    progressTransform.d *= scale;

What? Scale is just in a and d.  And why not just use CGAffineTransformScale?


More information about the webkit-reviews mailing list