[webkit-reviews] review granted: [Bug 186867] Web Inspector: All non-Same-Site cookies are marked as Same-Site Strict in Storage tab : [Attachment 343192] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 186867: Web Inspector: All non-Same-Site cookies are marked as Same-Site
Strict in Storage tab
https://bugs.webkit.org/show_bug.cgi?id=186867

Attachment 343192: Patch

https://bugs.webkit.org/attachment.cgi?id=343192&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 343192
  --> https://bugs.webkit.org/attachment.cgi?id=343192
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343192&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:143
> +		   sameSite: !cookie.sameSite || cookie.sameSite ===
WI.Cookie.SameSiteType.None ? "" :
WI.Cookie.displayNameForSameSiteType(cookie.sameSite),

I think this reads better as:

sameSite: cookie.sameSite && cookie.sameSite !== WI.Cookie.SameSiteType.None ?
WI.Cookie.displayNameForSameSiteType(cookie.sameSite) : "",